PLEASE fix dshowserver.patch to work with xine-lib-1.2!

[GoogleCodeExporter]

What steps will reproduce the problem?
1. apply current dshowserver.patch to xine-lib-1.2 source and in the end
you won't see dshowserver in the engine list, and it won't work.

What is the expected output? What do you see instead?
expected to see dshowserver work in xine-lib-1.2...  but it doesn't.

Please provide any additional information below.

not much is needed to fix it from what I was told..  basically: 
"just a few filenames, some details near the end of dshowserver.c
(get_identifier & get_description – remove "get_" and either call the
functions or use their return values directly in the assignments), replace
18 with 19 in xine_plugin_info[] and adjust some #include "..." (mostly,
you want <xine/...>).  There may be one or two other details."

Original issue reported on code.google.com by user....@gmail.com on 24 Jun 2008 at 1:32

[GoogleCodeExporter]

I have no plans to support xinelib 1.2 at this time.
However if someone were to send me a working patch, I'd be happy to include it.

Original comment by alannis...@gmail.com on 24 Jun 2008 at 9:36

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I have modified the path to reflect the new 1.2 directory structure (see 
attachment).

The patch compiles, but doesn't work. I get a segfault when the plugin is used, 
so
some more work needs to be done to get it working (probably some change in the
library). I'll try to look into it this weekend.

The changes I made:
* Moved all code to the src/video_dec directory
* Renamed xine_xmalloc() to malloc(), because xine_xmalloc is now deprecated
* get_identifier and get_description are replaced by identified and 
description, no
function reference needed, just the string
* changed API version to 19 (was 18)
* changed include path to use new <xine/...> location

Original comment by ebor...@gmail.com on 18 Jul 2008 at 9:26

Attachments:

• xine-1.2-dshowserver.diff.gz

[GoogleCodeExporter]

eborned, thanks for your efforts!  Hopefully you'll be able to figure out why it
segfaults this weekend.  On behalf of many people, thanks!

Original comment by user....@gmail.com on 18 Jul 2008 at 4:22

[GoogleCodeExporter]

I rechecked the segfault issue, but it also happens when I use 1.1.14, so maybe 
it's
not related to the version change of Xine.

Original comment by ebor...@gmail.com on 18 Jul 2008 at 6:23

[GoogleCodeExporter]

I applied this patch (fixed for current dshowserver)

Original comment by alannis...@gmail.com on 9 Jan 2010 at 8:35

• Changed state: Fixed