search

chenzhutian / hexo-all-minifier

A plugin for Hexo that optimizes HTML, CSS, JS and imagages, and it can optionally deploys your blog.
MIT License
275 stars 30 forks source link

fix: issue #87 #88

Open kuretru opened 4 years ago

kuretru commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #88 into master will increase coverage by 0.02%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   94.73%   94.76%   +0.02%     
==========================================
  Files           5        5              
  Lines         190      191       +1     
==========================================
+ Hits          180      181       +1     
  Misses         10       10
Impacted Files Coverage Δ
lib/concatJS.js 97.43% <66.66%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 680033b...ab3d631. Read the comment docs.

chenzhutian commented 4 years ago

Hello, 有一个检测没过, 能麻烦你看看么?

kuretru commented 4 years ago

不太清楚codecov/patch这个方法或者说行为具体做了什么。我猜测一个可能的原因是，我更改的那行代码一直没被测试用例覆盖到，因此他认为测试失败，参考此链接，99行恰巧一直未被测试用例覆盖。根据此猜测，可能需要增加一个启用front选项的测试用例。

chenzhutian commented 4 years ago

OK, 我mark一下, 过两天看看, 我最近在开会 多谢多谢