search

cheonjaeung / gridlayout-compose

Missing non lazy grid layout for Compose Multiplatform.
https://cheonjaeung.github.io/gridlayout-compose
Apache License 2.0
47 stars 4 forks source link

Vertical Grid spacedBy #14

Closed Voroz closed 9 months ago

Voroz commented 9 months ago

The library is a great addition that's just what I needed but unfortunately there's a bug with spacing. This example will show that horizontalArrangement spacedBy does not add any spacing at all. This issue does not happen with the official LazyVerticalGrid.

VerticalGrid(
        columns = SimpleGridCells.Fixed(2),
        verticalArrangement = Arrangement.spacedBy(8.dp),
        horizontalArrangement = Arrangement.spacedBy(8.dp)
    ) {
        repeat(4) {
            Surface(
                modifier = Modifier
                    .height(100.dp)
                    .fillMaxWidth()
            ) {

            }
        }
    }
cheonjaeung commented 9 months ago

Thanks for reporting this bug! I think this issue is same to #13 issue. When this bug is fixed, I gonna close this issue with #13.

Voroz commented 9 months ago

Thanks for reporting this bug! I think this issue is same to #13 issue. When this bug is fixed, I gonna close this issue with #13.

Hey,

You fixed this bug now right? I noticed you made a commit regarding measuring. Do you plan on creating a new library version soon? I think that this is a major issue so it would be good to have a new version as soon as possible.