search

cheprasov / php-redis-client

RedisClient is a fast, fully-functional and user-friendly client for Redis, optimized for performance. RedisClient supports the latest versions of Redis starting from 2.6 to 6.0
MIT License
126 stars 41 forks source link

Drop support for PHP 5.5, 5.6, 7.0 and 7.1. Test against 7.4. #74

Closed nickdnk closed 2 years ago

nickdnk commented 4 years ago

It doesn't seem to pass. I don't know why though.

See the log here: https://travis-ci.com/github/nickdnk/php-redis-client/jobs/347759390

nickdnk commented 4 years ago

So I did a little reading. It seems that you'd have to update PHPUnit to a later version. I tried with 5.x, but it still didn't work, which lead me to https://github.com/sebastianbergmann/phpunit/issues/3728

Perhaps it's time to release a 2.0 of this package with support for only PHP 7.2, 7.3 and 7.4? That would allow the latest version of PHP 8 to be used.

nickdnk commented 4 years ago

So I got it to work: https://travis-ci.com/github/nickdnk/php-redis-client

cheprasov commented 4 years ago

Hi @nickdnk Thanks a lot for your contribution, I work on it, and the RedisClient will stop support old PHP versions, and the client will be released for 7.4 and above.

Also, I am sorry, but I can not merge your PR because described work requires a lot of refactoring, optimisation and changes, be patient patient.

nickdnk commented 4 years ago

Okay. Cool. I am using it with PHP 7.4 and it works fine (for me) so far. I will be patient :)

nickdnk commented 2 years ago

Hey @cheprasov

Any news here? I am slowly planning migration to PHP 8 and I really like this library.