search

cheqd / cheqd-node

Ledger/node software for cheqd's decentralised identity network. Built using the Cosmos SDK blockchain framework.
https://docs.cheqd.io/node
Apache License 2.0
64 stars 43 forks source link

build(deps): Bump bufbuild/buf-setup-action from 1.30.0 to 1.30.1 #726

Closed dependabot[bot] closed 7 months ago

dependabot[bot] commented 7 months ago

Bumps bufbuild/buf-setup-action from 1.30.0 to 1.30.1.

Release notes

Sourced from bufbuild/buf-setup-action's releases.

v1.30.1

Release v1.30.1

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
ankurdotb commented 7 months ago

@Eengineer1 This was originally just a Dependabot update, but it drew my attention to double-checking whether our Buf files are correct/in-line with what should be expected for the mainnet upgrade (since the correct way to test this bump on Buf action is to run a make proto-gen):

Screenshot 2024-04-09 at 13 40 25
  1. proto/buf.lock still references tendermint as the package. Does this need to be changed to cometbft? https://buf.build/cometbft/cometbft Seems to be a dependency/not directly referenced, so we might need to look at whether the buf-* files are correct. There's a table on this page that suggests the protobuf types have changed, and therefore need to be updated, protobufs re-generated etc.
  2. In buf.yaml, I left a comment saying "Update these dependencies when our chain goes to Cosmos SDK v0.47". I think this is because the buf packages for Cosmos SDK have been renamed/changed/moved but maybe it was a different reason.
  3. buf.gen.gogo.yaml references v1alpha1 of ORM models. Is this correct/accurate for our Cosmos and CometBFT/Tendermint versions or has it changed?
  4. In make/proto.mk, do we need to change the containerProtoVer?
  5. Any other changes in the Buf files which could impact make proto-gen? This section of the Cosmos v0.47 upgrade guide may be relevant.
ankurdotb commented 7 months ago

Moved all of the questions to ClickUp, so that I can merge the PR for just the action bump instead.