search

cher-nov / cryptg

Official Telethon extension to provide much faster cryptography for Telegram API requests.
https://pypi.org/project/cryptg/
Creative Commons Zero v1.0 Universal
75 stars 24 forks source link

CI fixes / package build fixes #19

Closed a68366 closed 2 years ago

a68366 commented 2 years ago

Fixes python package build.

I've also enabled win32 build, since currently published v0.2 had it. It shouldn't be a problem, unless the rust code is somehow tied to a specific architecture, i guess. Tried using it on win 7 x32, it worked fine.

Build log is available here: https://github.com/a68366/cryptg/actions/runs/2181002754 And the resulting packages are here: https://test.pypi.org/project/cryptgtest/0.3.1/

Closes #15 Closes #17

Lonami commented 2 years ago

Thanks, since this removes (and not moves) licensing info I'll wait on @cher-nov to give the thumbs up before merging.

cher-nov commented 2 years ago

Thanks, since this removes (and not moves) licensing info I'll wait on @cher-nov to give the thumbs up before merging.

This is definitely bad, and I would strongly disapprove such solution, sorry.

Lonami commented 2 years ago

I'm not sure what the implications on removing those files from there actually are. I would have to do some research before I can argue in favour of this too.

a68366 commented 2 years ago

Force-pushed the branch. I used layout similair to what e.g. pandas (see LICENSES) and ansible (licenses) do.

Since you want to have 3rd party lincenses in the repo, I assume that you also want to ship them with source distribution, so I included the directory in MANIFEST.in.

Lonami commented 2 years ago

This seems like the best of both worlds, @cher-nov what do you think of it now?

cher-nov commented 2 years ago

This seems like the best of both worlds, @cher-nov what do you think of it now?

Let's accept until I have some time to finally get to this project and put things in order.