search

cher-nov / cryptg

Official Telethon extension to provide much faster cryptography for Telegram API requests.
https://pypi.org/project/cryptg/
Creative Commons Zero v1.0 Universal
75 stars 24 forks source link

Add Cargo.lock to the repo #20

Closed K900 closed 2 years ago

K900 commented 2 years ago

Exactly what it says on the tin. Right now it's not really possible to build the repo reproducibly as the dependencies aren't locked, which is a pretty big no-no for distribution packaging.

Lonami commented 2 years ago

I guess we're technically building "an end-product" and not a library, even if the end-product is a library (for another language). Given it makes sense as per the book on Cargo.toml vs Cargo.lock and it's useful to do, we probably should commit the file.

K900 commented 2 years ago

Yeah, "no Cargo.lock for libraries" thing is mostly there for the kind of libraries that you'd include in another project, i.e. something that does not produce artifacts by itself. In this case, there is an artifact, namely the Python extension, so I'd say a Cargo.lock makes sense.

Lonami commented 2 years ago

Do you need a new version to be published to PyPi, or is this okay?

K900 commented 2 years ago

A new version would definitely be preferable, but I'm not really in a hurry, if you've got other changes you want to bundle with that.