ci: run on more event, publish only when needed

cher-nov / cryptg

Official Telethon extension to provide much faster cryptography for Telegram API requests.

https://pypi.org/project/cryptg/

Creative Commons Zero v1.0 Universal

75 stars 24 forks source link

ci: run on more event, publish only when needed #26

Closed Rongronggg9 closed 2 years ago

Rongronggg9 commented 2 years ago

Close #21

push w/o a tag: https://github.com/Rongronggg9/cryptg/actions/runs/3338149220 workflow_dispatch w/ publish unchecked: https://github.com/Rongronggg9/cryptg/actions/runs/3338160775 workflow_dispatch w/ publish checked: https://github.com/Rongronggg9/cryptg/actions/runs/3338161699

Lonami commented 2 years ago

Cool, although the builds can take over an hour. I'm not much into CI but what are your thoughts on this? Is it fine for them to run for so long or perhaps it'd be better to run them only on a few events?

Rongronggg9 commented 2 years ago

It is fine to run for so long and for so many events. GHA is free of charge for public repositories and a lot of open-sourced projects are already "eating" GHA even more hungrily than us :) The reason why I added these events is to do rough tests (if it is buggy, builds will probably fail). Merging a PR before workflows are finished is pretty OK if it passed the test "in your mind". You may cancel a workflow run if needed.