Closed vsnever closed 3 months ago
I think this is a good idea. We already have some unit tests for lineshapes, but it would be good to check when doing this re-factor that the coverage is sufficient. That would give more confidence that the changes won't break anything.
Implemented in #400.
The
lineshape.pyx
already contains almost 1000 lines of code and the implementation of #393 will bloat it even more. I think it's time to create a separate submodule for line shape models. Here is a suggested file structure, with an indication of which class/function goes where. This change will not affect user code.@jacklovell, @Mateasek, if you agree, I'll make the change along with implementation of #393.