search

cherab / core

The core source repository for the Cherab project.
https://www.cherab.info
Other
44 stars 24 forks source link

Replace the half-sum with numerical integration when calculating the bremsstrahlung spectrum #402

Closed vsnever closed 9 months ago

vsnever commented 1 year ago

This fixes #395 by adding integrator argument to the Bremsstrahlung emission model. The new BremsFunction(Function1D) class is added for compatibility with Integrator1D.

Update. This also fixes #409 by replacing the numerical constant with an exact expression and changing the reference to bremsstrahlung equation in the docstring.

jacklovell commented 1 year ago

Would be good to have test coverage of this too.

vsnever commented 1 year ago

Would be good to have test coverage of this too.

Done. I also added a fix for #409 so as not to rewrite the test in a separate PR.