cherab / core

The core source repository for the Cherab project.
https://www.cherab.info
Other
44 stars 24 forks source link

NotImplementedError in TestLaserSpectrum unit test #417

Closed vsnever closed 1 year ago

vsnever commented 1 year ago

The TestLaserSpectrum unit test raises NotImplementedError with Cython 3.0 because the evaluate() method is not implemented in the base LaserSpectrum class. For some reason this exception was ignored with Cython 0.29.

I suggest doing the tests for the ConstantSpectrum as it is the simplest LaserSpectrum subclass that implements the evaluate() method.

vsnever commented 1 year ago

Fixed in #418.