cherab / core

The core source repository for the Cherab project.
https://www.cherab.info
Other
44 stars 24 forks source link

Pass the total ion density to BeamCXPEC in BeamCXLine and add donor_metastable attribute to BeamCXPEC #444

Closed vsnever closed 1 month ago

vsnever commented 2 months ago

This PR fixes #441 and #411.

I've added a warning to the changelog that this fix affects user results. The affected figures in the documentation have also been replaced.

Please note that tests for Python 3.9 and 3.10 will fail due to #442.

vsnever commented 1 month ago

Hi @Mateasek,

Thanks for review. In the comment I tried to explain why I added the donor_metastable attribute to the base BeamCXPEC and why I included the fixes for #411 and #441 in the same PR. But if you are not happy with that, I can move a fix for #411 in a separate PR.