Feature/quadrangle mesh

cherab / solps

Other

6 stars 5 forks source link

Feature/quadrangle mesh #47

Closed Mateasek closed 3 years ago

Mateasek commented 3 years ago

@vsnever could you please look at this PR? Thanks.

Mateasek commented 3 years ago

Hi @vsnever , thank you very much for the review and suggestions! I applied the changes

jacklovell commented 3 years ago

Thanks Matej, and thanks Vlad for the review!

vsnever commented 3 years ago

In the review I mentioned that all plot_mesh() calls in the demos should be replaced with plot_triangle_mesh() or plot_quadrangle_mesh() calls as plot_mesh() is no longer available. However, I completely forgot about this when I approved the changes the next day, sorry.

Mateasek commented 3 years ago

Me too, I will make a separate PR to fix it. Thanks for remembering.