cherab / solps

Other
6 stars 5 forks source link

Add H-alpha emissivity calculated with EIRENE to SOLPSSimulation. #49

Closed vsnever closed 3 years ago

vsnever commented 3 years ago

This PR adds new attributes to SOLPSSimulation, which are used to store the molecular and total (atomic + molecular) H-alpha emissivities calculated with EIRENE. Like all other simulation data, the emissivities are also available as Function2D and Function3D objects. This PR fixes #48.

@Mateasek, @jacklovell, what do you think on this?

jacklovell commented 3 years ago

I'm happy with this PR. @Mateasek are you happy for it to be merged too?

Mateasek commented 3 years ago

Sorry for the delay, no suggestions from my side. Thanks for the work @vsnever