Replace solps_total_radiated_power() with make_solps_emitter() and remove SOLPSTotalRadiatedPower

cherab / solps

Other

6 stars 5 forks source link

Replace solps_total_radiated_power() with make_solps_emitter() and remove SOLPSTotalRadiatedPower #52

Closed vsnever closed 3 years ago

vsnever commented 3 years ago

This PR replaces solps_total_radiated_power() with a more general make_solps_emitter() and removes redundant SOLPSTotalRadiatedPower, because in make_solps_emitter() a combination of RadiationFunction and VolumeTransform is used instead. A script that demonstrates the usage of make_solps_emitter() on the example of total radiated power is added.

This fixes #50.

vsnever commented 3 years ago

Hi @jacklovell, thanks for the review. I improved the demo as you suggested. Also, I set the display_unsaturated_fraction parameter of PowerPipeline2D to 0.9999 to prevent underexposure that can occur in case of poor ray statistics.