BasicSolpsLineEmitter is also affected by the issue cherab/core#235. Namely, electron temperature is used for thermal broadening of the line instead of species temperature. I suggest making SOLPS line emitter a subclass of PlasmaModel with user-provided emissivity defined as a SOLPSFunction2D. When converted to PlasmaModel, it will support any line shape model available in Cherab, not just GaussianLine.
This emitter might be useful when #49 is merged.
I'll make a draft PR to show the changes I propose.
vsnever
commented
2 years ago
BasicSolpsLineEmitteris also affected by the issue cherab/core#235. Namely, electron temperature is used for thermal broadening of the line instead of species temperature. I suggest making SOLPS line emitter a subclass ofPlasmaModelwith user-provided emissivity defined as aSOLPSFunction2D. When converted toPlasmaModel, it will support any line shape model available in Cherab, not justGaussianLine.This emitter might be useful when #49 is merged.
I'll make a draft PR to show the changes I propose.