Make SOLPS line emitter a PlasmaModel with user-provided emissivity

cherab / solps

Other

6 stars 5 forks source link

Make SOLPS line emitter a PlasmaModel with user-provided emissivity #56

Closed vsnever closed 2 years ago

vsnever commented 3 years ago

This fixes #55 by converting SOLPS line emitter to a PlasmaModel. With this change, it supports any line shape model available in Cherab. Also, BasicSolpsLineEmitter is renamed to SOLPSLineEmitter.

vsnever commented 2 years ago

I've added a demo, so this PR is now ready for review. The patch cherab/core#323 must be applied first otherwise the demo may not work correctly.

jacklovell commented 2 years ago

Happy to merge after @Mateasek reviews.

Mateasek commented 2 years ago

I think this can be accepted @jacklovell