Closed vsnever closed 2 years ago
There is a copy paste error in SOLPSSimulation.electron_velocities_cylindrical setter: https://github.com/cherab/solps/blob/a4e6b63b45654d7bf438a27eb47b92f544474b67/cherab/solps/solps_plasma.py#L310-L318 Instead of this:
SOLPSSimulation.electron_velocities_cylindrical
velocities[:, 2] = -value[:, 1]
should be this:
velocities[2] = -value[1]
I think we need unit tests to track bugs like this. I'll start adding them.
Fixed in PR #64.
vsnever
commented
2 years ago vsnever
commented
2 years ago
There is a copy paste error in
SOLPSSimulation.electron_velocities_cylindricalsetter: https://github.com/cherab/solps/blob/a4e6b63b45654d7bf438a27eb47b92f544474b67/cherab/solps/solps_plasma.py#L310-L318 Instead of this:should be this:
I think we need unit tests to track bugs like this. I'll start adding them.