search

cherfia / chromiumly

A lightweight Typescript library that interacts with Gotenberg's different modules to convert a variety of document formats to PDF files.
MIT License
61 stars 7 forks source link

feat: support assets for html conversion #332

Closed franciscopantojag closed 6 months ago

franciscopantojag commented 6 months ago

Description

Support Additional files for HTML conversion It is possible to send additional files which are referenced on index.html as you can see on the gotenberg docs

cherfia commented 6 months ago

@franciscopantojag Thanks a bunch for your contribution 👏 Could you please update html.converter.test.ts to reflect the changes?

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f147583) 99.18% compared to head (dc6ff25) 98.79%. Report is 4 commits behind head on main.

:exclamation: Current head dc6ff25 differs from pull request most recent head 3a88113. Consider uploading reports for the commit 3a88113 to get more accurate results

Files Patch % Lines
src/chromium/converters/html.converter.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #332 +/- ## ========================================== - Coverage 99.18% 98.79% -0.40% ========================================== Files 15 15 Lines 246 248 +2 Branches 59 60 +1 ========================================== + Hits 244 245 +1 - Misses 2 3 +1 ``` | [Flag](https://app.codecov.io/gh/cherfia/chromiumly/pull/332/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Taha+Abdelmoutaleb+Cherfia) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/cherfia/chromiumly/pull/332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Taha+Abdelmoutaleb+Cherfia) | `98.79% <50.00%> (-0.40%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Taha+Abdelmoutaleb+Cherfia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

franciscopantojag commented 6 months ago

Hello @cherfia , awesome project! Just added some tests, thanks for the suggestion 😊