Photometry table in 'Source.py'

cheritier / OOPAO

Object Oriented Python Adaptive Optics

https://cheritier.github.io/OOPAO/

GNU General Public License v3.0

16 stars 17 forks source link

Photometry table in 'Source.py' #13

Open ppathak8 opened 8 months ago

ppathak8 commented 8 months ago

Just a comment, the zero point value for the I-band is 30% more compared to what I get in my calculation.
The values for other I-filters (I1, I2, I3, ..), seems to be fixed: 2.7e12
elsewhere in the code I don't see the use of filter bandwidth, which can account for this discrepancy.

Can you let me know, if I am missing something?

cheritier commented 8 months ago

Hi, The values were imported from the OOMAO standard photometry class so there might be a few discrepancy, especially on the zero-point (We usually consider the number of photon per sub-aperture, not so much the magnitude). The bandwidth is indeed not used in the code, everything is considered to be monochromatic around the central wavelenght specified in the photometry class. _ if you need, you can also redefine another photometry class with your own values

ppathak8 commented 7 months ago

Yes, I had looked up OOMAO, and I found the same there as well.

The number of photons will vary with magnitude, which is correctly calculated.
If it is monochromatic then it's fine, but this will impact the correct value of photons per sub-aperture you get for other bands of "I".

cheritier commented 7 months ago

Indeed, If you have the correct values, feel free to create a pull request to update the current values.

ppathak8 commented 7 months ago

Will do it in the coming months.

torin5 commented 2 months ago

Hi there, It seems this change introduced a couple indentation errors in Source.py. I made a PR to fix it.