cherokee / webserver

Cherokee Web Server
GNU General Public License v2.0
564 stars 104 forks source link

./configure --without-python creates a broken build #1139

Open jolexa opened 10 years ago

jolexa commented 10 years ago

See also: https://bugs.gentoo.org/show_bug.cgi?id=514530

The relevant commit is: https://github.com/cherokee/webserver/commit/bd924867e9b595758571b7d79eb7926e8b061aaa

because it generates a Makefile like so: % grep PYTHON doc/Makefile PYTHON = no ASCIIDOC = $(PYTHON) $(top_srcdir)/doc/build/asciidoc.py --conf-file=$(top_srcdir)/doc/build/doc.conf

and then the build fails:

no ../doc/build/asciidoc.py --conf-file=../doc/build/doc.conf -o index.html ../doc/index.txt make[2]: no: Command not found

skinkie commented 10 years ago

I wonder if 'false' would work.

pigmej commented 10 years ago

@skinkie false would result the same error.

I think --without-python should not reset $PYTHON, (because one might want to build doc, but not use python in/with cherokee).

So the question is, shall we disable documentation when --without-python is given, or not.

skinkie commented 10 years ago

Is there an option to disable the documentation right now?

pigmej commented 10 years ago

@skinkie

Checking for python https://github.com/cherokee/webserver/blob/master/doc/Makefile.am#L1 should be the same as in https://github.com/cherokee/webserver/blob/master/configure.ac#L1355-L1387