search

cherokee / webserver

Cherokee Web Server
GNU General Public License v2.0
561 stars 105 forks source link

Copyright notices have been removed from the code #70

Open rasa opened 11 years ago

rasa commented 11 years ago

I contributed to this code a while back, and found that my copyright notices were removed. In fact, I found this was done on numerous occasions to other contributors, as well (see below). The is probably not only illegal, but bad form, in that developers may not want to contribute to a project where their credit can't be listed.

Many of the entries listed below are valid deletes, but the following are obviously not:

2c39092 (6392):- * Copyright (C) 2002-2005 OpenVPN Solutions LLC info@openvpn.net 2c39092 (6393):- * Copyright (C) 2007 Ross Smith II 2c39092 (6429):- * Portions Copyright (C) 2007 Ross Smith II 2c39092 (6459):- * Portions Copyright (C) 2007 Ross Smith II 3dcb4dd (961):-* Copyright © 1995 by Jef Poskanzer jef@acme.com. 3dcb4dd (1293):-* Copyright © 1995 by Jef Poskanzer jef@acme.com. 809af53 (106):- * Copyright: Jef Poskanzer jef@acme.com 809af53 (140):- * Copyright 1995,1998,1999,2000,2001 by Jef Poskanzer jef@acme.com 809af53 (206):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com 809af53 (231):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com 809af53 (256):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com b6c69ad (4257):- \ Copyright (C) 1994-1998 Linus Torvalds & authors

Here is the complete list of copyright removals:

0895eb6 (766):- * Copyright (c) 2008 John Resig (jquery.com) 0895eb6 (1221):- * Copyright (c) 2008 Paul Bakaus (ui.jquery.com) 0895eb6 (1818):- * Copyright (c) 2007, 2008 Klaus Hartl (stilbuero.de) 116b782 (17192):-Copyright (c) 2007, Yahoo! Inc. All rights reserved. 116b782 (19526):- * Copyright (c) 2009 John Resig 116b782 (19536):- * Copyright 2009, The Dojo Foundation 116b782 (19551):- * Copyright (c) 2006 Klaus Hartl (stilbuero.de) 116b782 (19655):-/* Copyright (c) 2007 Paul Bakaus (paul.bakaus@googlemail.com) and Brandon Aaron (brandon.aaron@gmail.com || http://brandonaaron.net) 116b782 (19787):- * Copyright (c) 2007 George Smith 116b782 (19945):- * Copyright 2009 Giva, Inc. (http://www.givainc.com/labs/) 116b782 (20339):- * Copyright (c) Denis Howlett denish@isocra.com 116b782 (20728):- * Copyright (c) 2007 cody lindley 116b782 (21053):- * Copyright (c) 2009 AUTHORS.txt (http://jqueryui.com/about) 116b782 (21578):- * Copyright (c) 2008 Richard D. Worth (rdworth.org) 116b782 (22081):- * Copyright (c) 2008 Paul Bakaus 116b782 (22649):- * Copyright (c) 2008 Paul Bakaus 116b782 (23425):- * Copyright (c) 2009 AUTHORS.txt (http://jqueryui.com/about) 254368b (60):-Copyright (c) 2004, Jan Kneschke, incremental 280e7d0 (6087):-Copyright (c) 2005, the Lawrence Journal-World 2c39092 (6392):- * Copyright (C) 2002-2005 OpenVPN Solutions LLC info@openvpn.net 2c39092 (6393):- * Copyright (C) 2007 Ross Smith II 2c39092 (6429):- * Portions Copyright (C) 2007 Ross Smith II 2c39092 (6459):- * Portions Copyright (C) 2007 Ross Smith II 3d2b87c (163):- * Copyright © Denis Howlett denish@isocra.com 3dcb4dd (961):-* Copyright © 1995 by Jef Poskanzer jef@acme.com. 3dcb4dd (1293):-* Copyright © 1995 by Jef Poskanzer jef@acme.com. 423d6fa (317):- * Copyright (c) 1998 Todd C. Miller Todd.Miller@courtesan.com 42a0885 (30):- Copyright (C) 1998-2002 Free Software Foundation, Inc. 42a0885 (926):- Copyright (C) 1998-2002 Free Software Foundation, Inc. 42a0885 (1048):- * Copyright (C) 2001 Farooq Mela. 42a0885 (1121):- * Copyright (C) 2001 Farooq Mela. 42a0885 (1262):- * Copyright (C) 2001 Farooq Mela. 42a0885 (1359):- * Copyright (C) 2001 Farooq Mela. 42a0885 (2364):- * Copyright (C) 2001 Farooq Mela. 58b913a (33):- * Copyright (c) 2007 Jörn Zaefferer, Frank Marcia 72cf49e (231):- * Copyright (c) 2000-2003 The Apache Software Foundation.
7d3d6a2 (696):-Copyright (C) 2002-2008 Stuart Rackham. Free use of this software is granted 7e1ff18 (62):- * Copyright (c) 2006 - 2008 Jörn Zaefferer 809af53 (106):- * Copyright: Jef Poskanzer jef@acme.com 809af53 (140):- * Copyright 1995,1998,1999,2000,2001 by Jef Poskanzer jef@acme.com 809af53 (206):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com 809af53 (231):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com 809af53 (256):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com 81a5bf7 (74):- Copyright (C) 1989, 1991 Free Software Foundation, Inc., 81a5bf7 (385):- Gnomovision version 69, Copyright (C) year name of author 9ba6eaf (15):-# Copyright (c) 2006 Sun Microsystems, Inc. abd2a3f (280):- Copyright (c) 1997-2003 University of Cambridge abd2a3f (635):- Copyright (c) 1997-2003 University of Cambridge abd2a3f (1319):- Copyright (c) 1997-2003 University of Cambridge abd2a3f (9626):-/* Copyright (c) 1997-2003 University of Cambridge / ac87904 (602):- * Copyright (c) 2008 John Resig (jquery.com) addcbd8 (3075):- Copyright (c) 1996 L. Peter Deutsch addcbd8 (3765):- Copyright (C) The Internet Society (1999). All Rights Reserved. addcbd8 (13538):- Copyright (C) The Internet Society (1999). All Rights Reserved. addcbd8 (13620):- Copyright (C) The Internet Society (2000). All Rights Reserved. addcbd8 (14275):- Copyright (C) The Internet Society (2000). All Rights Reserved. ae9d971 (59605):+/ Digest::SHA1 by Gisle Aas Copyright 1999-2003, Uwe Hollerbach Copyright 1997 / b60ec79 (714):- * Portions created by the Initial Developer are Copyright (C) 2007 b6c69ad (4257):- * Copyright (C) 1994-1998 Linus Torvalds & authors c238f0c (36):- * Copyright (C) 1995-1997 by Sam Rushing rushing@nightmare.com c238f0c (37):- * Copyright (C) 2005 by Germanischer Lloyd AG c238f0c (38):- * Copyright (C) 2001-2005 by IronPort Systems, Inc. c238f0c (1590):- * Copyright (C) 1995 by Sam Rushing rushing@nightmare.com c238f0c (1591):- * Copyright (C) 2005 by Germanischer Lloyd AG c238f0c (1592):- * Copyright (C) 2001-2005 by IronPort Systems, Inc. c83084a (87):-Copyright (c) 1997-2007 The PHP Group c83084a (88):-Zend Engine v2.2.0, Copyright (c) 1998-2007 Zend Technologies d30f8df (18):-# Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, d30f8df (464):-# Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,

alobbs commented 11 years ago

Most of those supposed removal came from files that were deleted from the tree. Unless some mistake was made, I don't think any notable copyright entry was removed.

danielniccoli commented 11 years ago

No objection by rasa :) I’ll mark this as a question and will close this issue until further comments will be made.

rasa commented 11 years ago

As I originally said, the following entries are OBVIOUSLY examples of valid copyright notices being improperly removed. I would appreciate someone taking the time to put (at least) these entries back in the code, as their removal is both bad form and most likely illegal.

2c39092 (6392):- * Copyright (C) 2002-2005 OpenVPN Solutions LLC info@openvpn.net 2c39092 (6393):- * Copyright (C) 2007 Ross Smith II 2c39092 (6429):- * Portions Copyright (C) 2007 Ross Smith II 2c39092 (6459):- * Portions Copyright (C) 2007 Ross Smith II 3dcb4dd (961):-* Copyright © 1995 by Jef Poskanzer jef@acme.com. 3dcb4dd (1293):-* Copyright © 1995 by Jef Poskanzer jef@acme.com. 809af53 (106):- * Copyright: Jef Poskanzer jef@acme.com 809af53 (140):- * Copyright 1995,1998,1999,2000,2001 by Jef Poskanzer jef@acme.com 809af53 (206):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com 809af53 (231):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com 809af53 (256):-* Copyright (c) 1999,2000 by Jef Poskanzer jef@acme.com b6c69ad (4257):- \ Copyright (C) 1994-1998 Linus Torvalds & authors

alobbs commented 11 years ago

As I said, lot of that code was either removed or rewritten, for instance the (removal of the) win32 related bits.

Having said that, I must acknowledge we used a script to update those comments, so it'd be feasible some mistake were made. If you think that's the case, could you provide concrete references so we can fix them?

rasa commented 11 years ago

You're kidding right? I've already spent hours creating the list, which details many instances of valid copyrights being removed, and instead of honoring my request, you summarily remove my contributions entirely. Great way to inspire future developers to support your efforts. Way to go!

skinkie commented 11 years ago

Rasa: none of the commits that you mentions any filename at all, or refers to a portion of code that was in fact commited and is still being distributed... How can I or anyone else objectively check your statement without you giving any example? It seems that you just have grepped a list of diffs mentioning copyright.

rasa commented 11 years ago

I've provided a list that details the offending removals, that you, or anyone, can use to correct these errors. I'm not going to spend more time on a project that summarily removed all my work, when all I was asking for was that my contributions be recognized.

skinkie commented 11 years ago

"when all I was asking for was that my contributions be recognized."

Do read your "first post" again. You have never asked that, you made a statement that someone did so intentionally.

rasa commented 11 years ago

Skinkie, you are right, .. and wrong. Right, in that I didn't explicitly ask that my contributions be recognized, but that can certainly be inferred from my "first post". Wrong in that you claim I made a statement that someone did so intentionally, as I never stated that. Though obviously the complete removal of all of my contributions was certainly done intentionally.

skinkie commented 11 years ago

Again: I really don't have a clue what you have commited. I can honestly say that, and I did ask you what that was. Now you say "Though obviously the complete removal of all of my contributions was certainly done intentionally." - my guestimate is: "Maybe he commited something to the Win32 code?" Please be direct, saves everyone time and saves yourself a heavy weighted heart.

rasa commented 11 years ago

Skinkie: thank you for your reply. To find my contributions, simply click on the link to the left of my name, and search for my name.

Against my better judgement, I took the time to review the removals in question, and found the following valid copyrights have been removed:

https://github.com/cherokee/webserver/commit/2c39092#L265L5 OpenVPN Solutions LLC / Ross Smith II https://github.com/cherokee/webserver/commit/2c39092#L266L5 Ross Smith II https://github.com/cherokee/webserver/commit/2c39092#L267L5 Ross Smith II https://github.com/cherokee/webserver/commit/2c39092#L268L5 Gisle Vanem / Ross Smith II https://github.com/cherokee/webserver/commit/2c39092#L269L6 Ross Smith II https://github.com/cherokee/webserver/commit/423d6fa#L14L275 Todd C. Miller https://github.com/cherokee/webserver/commit/809af53#L3L334 Jef Poskanzer https://github.com/cherokee/webserver/commit/809af53#L3L671 Jef Poskanzer https://github.com/cherokee/webserver/commit/809af53#L5L62 Jef Poskanzer https://github.com/cherokee/webserver/commit/809af53#L6L54 Jef Poskanzer https://github.com/cherokee/webserver/commit/809af53#L7L74 Jef Poskanzer https://github.com/cherokee/webserver/commit/b6c69ad#L47L9 Linus Torvalds & authors

Please note, this is not an exhaustive review of the removals. I just don't have the time for that, sorry.

You're right, my heart is saddened that by my raising this issue, my entire contribution has been summarily removed. That was certainly not my intention. I simply wanted my name included with my contribution.

My guess is my contributions were removed because I raised this issue, and not because the windows port "didn't work properly". There are numerous examples of web servers working fine in Windows: Apache, Nginex, thttpd, etc. Plus, the documentation and web site still claim a Windows port is available. For example, the download page states "Developers are welcome to join the effort of finishing the port of Cherokee to Windows. Do not hesitate to join us!"

And I'm deeply saddened that instead of simply adding my name back to the code, it was unilaterally decided to exclude over 92% of the computers in the world from ever having the opportunity to profit from our efforts.

skinkie commented 11 years ago

So my guess was right, you have contributed to the windows port... This would be handy at the start of the discussion. The only part I am missing is the part were your actual commit were so I could have validated it, the only thing that those links show is the removal of your name.

And please don't refer to me as "you've decided", I did not decide anything. Since I was the last person that did touch the Windows code years ago (see my patches) I do agree on the fact that in 2013 there are better priorities.

danielniccoli commented 11 years ago

We just migrated the website to Github. There is a lot of cleanup to do. Removing the Windows-parts from is already on the list.