The Http Reverse Proxy Handler does not provide an "Allow X-Sendfile" option like other handlers.

cherokee / webserver

Cherokee Web Server

GNU General Public License v2.0

564 stars 104 forks source link

The Http Reverse Proxy Handler does not provide an "Allow X-Sendfile" option like other handlers. #760

Open danielniccoli opened 11 years ago

danielniccoli commented 11 years ago

Original author: jdn...@gmail.com (December 06, 2010 06:18:30)

Enhancement request: The Http Reverse Proxy Handler does not provide an "Allow X-Sendfile" option like other handlers. This seems like an oversight. I'm having to use to nginx or Apache to get this feature for my reverse proxy servers.

Original issue: http://code.google.com/p/cherokee/issues/detail?id=1064

danielniccoli commented 11 years ago

From alobbs on December 28, 2010 20:44:22 Other server's documentation regarding the X-Sendfile support:

Apache: https://tn123.org/mod_xsendfile/
Lighttpd: http://blog.lighttpd.net/articles/2006/07/22/mod_proxy_core-got-x-sendfile-support
Nginx: http://wiki.nginx.org/XSendfile

danielniccoli commented 11 years ago

From jdn...@gmail.com on December 28, 2010 20:53:48 In case it's helpful, a possible solution was outlined on the Cherokee mailing list last September.

http://lists.octality.com/pipermail/cherokee/2010-September/013521.html

danielniccoli commented 11 years ago

From alobbs on December 28, 2010 22:11:09 The following patch implements the X-Sendfile feature. Please, notice that it's a pre-alpha state patch. Even though it seems to work fine for my tests, some exhaustive testing is required before committing it to the repository.

It's interesting to notice that the X-Sendfile feature works with all sorts of objects, not only static files.

danielniccoli commented 11 years ago

From alobbs on December 29, 2010 10:47:15 http://svn.cherokee-project.com/changeset/6030 implemented it.

QA is definitely required for this patch. Please, give it a try.