cherryontech / website

Official website of the cherryOnTech squad!
https://cherryon.tech
MIT License
9 stars 40 forks source link

added definition of callback hell #216

Closed KatKowalik closed 1 year ago

KatKowalik commented 1 year ago

This PR fixes...

This PR adds a definition for "callback hell" to the dictionary.

What I did...

I added a definition for "callback hell" to the Dictionary.

How to test...

  1. Navigate to https://cherryon.tech/dictionary/
  2. Search the "callback hell" term.
  3. Read the definition.

I learned...

I learned that the alternative name for Callback Hell is the Pyramid of Doom, and I think I like this term better 😆

alliequintano commented 1 year ago

Hey! @khairahscorner pointed out to me that our build is failing for reasons unrelated to your PR. I am fixing that now and will update when it's working again! Sorry about that.

alliequintano commented 1 year ago

I am going to close and re-open your PR to retrigger the Netlify checks. A little weird but should work :D

alliequintano commented 1 year ago

I am going to close and re-open your PR to retrigger the Netlify checks. A little weird but should work :D

Okay that didn't work, but I pushed an empty commit to retrigger the checks and now your Netlify preview is ready!!

alliequintano commented 1 year ago

Get job so far @KatKowalik! Can you please fill out the PR description with the template provided?

KatKowalik commented 1 year ago

@alliequintano Done! :)

KatKowalik commented 1 year ago

@alliequintano I changed the beginning to be a sentence, the rest I think looked fine, but let me know if you want me to change it.

khairahscorner commented 1 year ago

Merging this PR since all looks good! @shelleymcq your suggestion would be a great addition too!