Closed TanyaPina closed 1 year ago
Hey Tanya - the definition looks great! I would recommend slightly editing your Pull Request 'How to test...' section. If the tester goes to the live site they won't see the definition for MVP as your branch hasn't been merged yet. Instead instruct them on how to run your branch locally or use the netlify deploy preview above to test your changes.
Hey Tanya - the definition looks great! I would recommend slightly editing your Pull Request 'How to test...' section. If the tester goes to the live site they won't see the definition for MVP as your branch hasn't been merged yet. Instead instruct them on how to run your branch locally or use the netlify deploy preview above to test your changes.
Great point @avinashi10! I've updated the link to be the Netlify deploy preview.
This PR fixes...
This PR adds the definition for "MVP" to the dictionary page.
What I did...
How to test...
I learned...
How a YAML file looks like!