cherryontech / website

Official website of the cherryOnTech squad!
https://cherryon.tech
MIT License
9 stars 40 forks source link

added mvp definition #219

Closed TanyaPina closed 1 year ago

TanyaPina commented 1 year ago

This PR fixes...

This PR adds the definition for "MVP" to the dictionary page.

What I did...

How to test...

  1. Navigate to the Netlify deploy preview here: https://deploy-preview-219--cherryontech.netlify.app/
  2. Scroll down to the term "MVP" or enter the term "MVP" in the search bar.

I learned...

How a YAML file looks like!

avinashi10 commented 1 year ago

Hey Tanya - the definition looks great! I would recommend slightly editing your Pull Request 'How to test...' section. If the tester goes to the live site they won't see the definition for MVP as your branch hasn't been merged yet. Instead instruct them on how to run your branch locally or use the netlify deploy preview above to test your changes.

TanyaPina commented 1 year ago

Hey Tanya - the definition looks great! I would recommend slightly editing your Pull Request 'How to test...' section. If the tester goes to the live site they won't see the definition for MVP as your branch hasn't been merged yet. Instead instruct them on how to run your branch locally or use the netlify deploy preview above to test your changes.

Great point @avinashi10! I've updated the link to be the Netlify deploy preview.