cherrypy / cherrypy

CherryPy is a pythonic, object-oriented HTTP framework. https://cherrypy.dev
https://docs.cherrypy.dev
BSD 3-Clause "New" or "Revised" License
1.8k stars 357 forks source link

Drop dependency on obsolete setuptools_scm_git_archive #2006

Closed mtelka closed 5 months ago

mtelka commented 6 months ago

What kind of change does this PR introduce?

What is the related issue number (starting with #)

Fixes #2005

What is the current behavior? (You can also link to an open issue here)

CherryPy depends on obsoleted setuptools_scm_git_archive.

What is the new behavior (if this is a feature change)?

The build dependency are updated to require setuptools_scm >= 7.0.0 and setuptools_scm_git_archive is no longer needed. See also https://github.com/Changaco/setuptools_scm_git_archive/blob/master/README.rst

Other information:

Checklist:

webknjaz commented 6 months ago

This should include updating .git_archival.txt FYI

mtelka commented 6 months ago

This should include updating .git_archival.txt FYI

Could you please be more specific? I'm unable to find such file in the git repo.

webknjaz commented 6 months ago

Oh, apparently we forgot to add it. That plugin you're removing requires this file and a .gitattributes change. Now, setuptools-scm implements this feature itself. So the same is necessary. Their readme has instructions. Also, I think there's a proper example in Cheroot.

mtelka commented 6 months ago

I'll leave this to somebody else then...