search

cherubicXN / hawp

Holistically-Attracted Wireframe Parsing [TPAMI'23] & [CVPR' 20]
MIT License
291 stars 51 forks source link

Want to add docker build and run example for your prediction #9

Open korvindest opened 3 years ago

korvindest commented 3 years ago

Hello, sorry to bother you via issue creation, but I failed to find another way for communication. I have created a basic example of using your prediction from a Docker container. It allows to run it every time in clear environment and easily run on any host just after docker and Nvidia drivers installation. Could you please allow me to push a new branch and create a pull request with this changes. I think it could be helpful for others who wants to see how you perfect research works.

Thanks, Felix

cherubicXN commented 3 years ago

Hi Felix,

Thank you very much for your interest and efforts. It is great to create a docker branch for this project.

I have created a new branch named docker, so I think you can create the pull request with your changes.

Thanks a lot!

Nan

korvindest commented 3 years ago

Hello, sorry to say, but I still can't push, even in branch "docker". What I have got:

git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain origin refs/heads/docker:docker
remote: Permission to cherubicXN/hawp.git denied to korvindest.
korvindest commented 3 years ago

CC: Hello @cherubicXN could you please fix access to the branch "docker"

cherubicXN commented 3 years ago

CC: Hello @cherubicXN could you please fix access to the branch "docker"

Hi @korvindest, did you fork my project to your own? After reading the guideline for the pull request, I think it is required to (1) fork the repo to your own, (2) pull your modification to your forked repo, and (3) create the pull request in the original repo.