search

chervonij / DFL-Colab

DeepFaceLab fork which provides IPython Notebook to use DFL with Google Colab
1.05k stars 265 forks source link

Changed the drive path #52

Closed sadavarterohit closed 1 year ago

sadavarterohit commented 2 years ago

The Google drive path in colab is not drive/My drive It is drive/Mydrive The space is not present, this recurring error has been rectified.

chervonij commented 2 years ago

@sadavarterohit

well, something very strange. I see that Colab has removed space from MyDrive. but then why don't I have any errors?

sadavarterohit commented 2 years ago

@chervonij

It is not an error that is thrown, it simply tries to find the path and is unsuccessful, so none of those commands actually work. Atleast that is what happened the first couple times that i ran the first few cells.

chervonij commented 2 years ago

@sadavarterohit that's what I'm talking about. import/export to Drive works for me even with this space. something strange is going on.

chervonij commented 2 years ago

ok, I can accept this PR, but if you bring your notebook, to the view of mine. if you look at the code changes, you are missing the "header" that is in my notebook.

chervonij commented 2 years ago

or I can just not take the PR and just fix path to Drive with my commit

sadavarterohit commented 2 years ago

@chervonij

Surprising how it doesn't work for me if it works for you. Strange indeed.

The view is different probably thanks to... well it being a notebook. So, although my notebook is likely to work anyway, feel free to do either of those things. I believe even your commit will have the same header file diffs, if you're cloning the repository again to make the changes.