search

ches-001 / metatune

Search for a model and corresponding hyperparameters that best model your data
Apache License 2.0
10 stars 5 forks source link

Decision Trees #6

Closed David2CN closed 1 year ago

ches-001 commented 1 year ago

Alright thank you. When I'm free I'll review and get back to you

ches-001 commented 1 year ago

I just checked this out, its good, but you missed the naming convention. The search space / ranges are supposed to have a '_space' suffix attached to it. For example, splitter: Iterable[str] = ("best", "random") ought to be splitter_space: Iterable[str] = ("best", "random")

David2CN commented 1 year ago

I just checked this out, its good, but you missed the naming convention. The search space / ranges are supposed to have a '_space' suffix attached to it. For example, splitter: Iterable[str] = ("best", "random") ought to be splitter_space: Iterable[str] = ("best", "random")

I have corrected this now.