Closed androa closed 9 years ago
Thank you for the PR! I was thinking about this need as well, it's a welcome change.
A few requests if you wouldn't mind updating:
sed
command in start.sh
? It seems problematic: a.) it appears incorrect, one path includes ./config
and the other doesn't, and b.) if a user happens to run a shell with this container and then manually runs start.sh
from there, it is going to behave badly if the user has changed directories from the default WORKDIR
of /kafka
and invokes start.sh
with an absolute path. I'd rather avoid that possibility, and not have a brittle implicit dependency on how WORKDIR
is set.Thanks!
I've rebased on your master and addressed your concerns, thanks for the review :)
Looks great, thanks for the prompt revision! I squashed your last commit into your first but it's all now integrated :rocket: (af14db9952 and 38baf1f7bd)
In order to connect to a ZooKeeper cluster, one should/need to have several ZooKeeper hosts in the connection string. This is a comma separated host:port pairs, each corresponding to a zk server.
For example: "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002".
The PR is backwards compatible with the ZOOKEEPER_HOST + ZOOKEEPER_IP settings.