ches / docker-kafka

Apache Kafka on Docker
https://hub.docker.com/r/ches/kafka/
146 stars 137 forks source link

Support multiple ZooKeeper servers #4

Closed androa closed 9 years ago

androa commented 9 years ago

In order to connect to a ZooKeeper cluster, one should/need to have several ZooKeeper hosts in the connection string. This is a comma separated host:port pairs, each corresponding to a zk server.

For example: "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002".

The PR is backwards compatible with the ZOOKEEPER_HOST + ZOOKEEPER_IP settings.

ches commented 9 years ago

Thank you for the PR! I was thinking about this need as well, it's a welcome change.

A few requests if you wouldn't mind updating:

Thanks!

androa commented 9 years ago

I've rebased on your master and addressed your concerns, thanks for the review :)

ches commented 9 years ago

Looks great, thanks for the prompt revision! I squashed your last commit into your first but it's all now integrated :rocket: (af14db9952 and 38baf1f7bd)