search

ches / docker-kafka

Apache Kafka on Docker
https://hub.docker.com/r/ches/kafka/
146 stars 137 forks source link

Add option for disabling unclean leader election #53

Open YarekTyshchenko opened 6 years ago

YarekTyshchenko commented 6 years ago

Its disabled by default here, in effort to be idiomatic, as it will be disabled in newer versions of kafka by default too. (from 0.11.0.0)

Let me know what you think, and if you need help backporting it to older tags (I'm interested in the v0.10.0.1 tag myself)

Btw, this is a fantastic repository. A while ago I tried to achieve a similar thing: getting kafka to run on a single docker host. You've kept this updated, and in pristine condition. :+1: good work!

YarekTyshchenko commented 6 years ago

Also, you should look into using Sigil (https://github.com/gliderlabs/sigil) for server config templating. Its much nicer than going through sed.