search

cheshire-cat-ai / docs

Documentation for the Cheshire Cat AI
https://cheshire-cat-ai.github.io/docs/
31 stars 27 forks source link

Enhancement forms documentation #157

Closed lucagobbi closed 1 month ago

lucagobbi commented 1 month ago

Hi there!

While reading the forms documentation, I noticed a few issues in the implementation example, including some typos and incorrect access to form_data (which is a dictionary, not directly a Pydantic model). I decided to make some corrections to address these.

Along the way, I also found and fixed a few additional typos and made some improvements to the English style for clarity.

I hope these changes are helpful. @valentimarco, excellent job documenting all of this!

valentimarco commented 1 month ago

tag @kodaline to have the 1-hour session of englisish

kodaline commented 1 month ago

tag @kodaline to have the 1-hour session of englisish

I didn't want to be too much nazi during our call Marco <3, otherwise our 1 hour session would have last 5 hours to fix all the stuff that I wanted to 😸... but I admit, I am a little nazi about language and syntax errors ahah

Anyway, if someone can assign me as reviewer to this, I would be happy because I see some stuff I would like to fix XD cc @pieroit

pieroit commented 1 month ago

@kodaline I don't know why github does not let me assign the review to you, I assigned the PR

Is it ok?

kodaline commented 1 month ago

@kodaline I don't know why github does not let me assign the review to you, I assigned the PR

Is it ok?

uuh cool, now I can do magic and assign me, thank you <3

valentimarco commented 1 month ago

looks good for me

kodaline commented 1 month ago

looks good for me

*to me @valentimarco 😝