search

cheshire-doge / pe

0 stars 0 forks source link

Ability to add an income of 0 #4

Open cheshire-doge opened 2 years ago

cheshire-doge commented 2 years ago

image.png

I think that users should not be able to add income values of 0 into the income list.

Steps to reproduce:

add /i /a 0 /c salary

nus-pe-script commented 2 years ago

Team's Response

In reality, there is no source of income that is $0. It is also rare that a single '0' could be a typo. Thus as normal users would almost never encounter such a situation, we feel this is a deliberate sabotage and hence have rejected the bug.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I think that it should still be considered an issue that can be fixed, and that while a typo of 0 might not really happen, it could be in the scenario where users intend to type 1000 but did not press the 1 key properly, resulting in 000 instead.