search

cheshire137 / gh-notifications-snoozer

Lists and filters and snoozing pull requests, oh my! This is an app for managing your notifications on GitHub by way of filtering issues and pull requests that are of interest to you.
MIT License
15 stars 10 forks source link

Night mode #104

Open cheshire137 opened 7 years ago

cheshire137 commented 7 years ago

It would be nice to see a dark theme available as an option. Beyond that, it would be cool to auto switch to the dark theme at night. We could approximate that by checking the current time and, if it's between 8 pm - 5 am, use the dark theme.

We don't have a settings page yet. This could be the first setting available on such a page, or we could omit having a settings page until we have more settings. Auto enabling the night theme based on time of day would be a way to avoid having a settings page for now.

samanthakem commented 7 years ago

Hi!

I started to work on this issue. What do you think about the layout I designed? (see picture below) As you can see, I also added the settings page but we can hide it while we don't have new settings features.

Once you say it looks ok, I will keep working on the other pages...

screen shot 2016-10-18 at 2 20 39 pm
cheshire137 commented 7 years ago

This looks nice to me! Thanks for starting on it. 😄

samanthakem commented 7 years ago

My pleasure @cheshire137! Glad it looks good :)

The idea is: I am creating a .less file called "DarkNight" (living in Settings/StyleThemes folder) that will overwrite the default colors once the night mode is activated.

samanthakem commented 7 years ago

@cheshire137 I am having an issue with the @import feature in less.

I was hoping I could do @import "StyleThemes/DarkNight.less" in 'Settings/Settings.less' file just so the Setting files would be responsible to manage this kinda of change (themes), however it does not work... it just works when I add @import "../Settings/StyleThemes/DarkNight.less" straight to the App.less file. Do you know how can I work with "nested" imports? Let me know if you got any questions about what I just said.

Thanks!

cheshire137 commented 7 years ago

Despite the file naming, all the LESS is included in all the views. It's just separated into files so it's easier to work with. You'll need to scope your styling via classes to keep it restricted to certain sections.

I would do the import in App.less with the other imports, since it'll all be applied across the whole app anyway.