search

cheshire137 / gh-notifications-snoozer

Lists and filters and snoozing pull requests, oh my! This is an app for managing your notifications on GitHub by way of filtering issues and pull requests that are of interest to you.
MIT License
15 stars 10 forks source link

Start on a CSS pipeline with LESS #13

Closed cheshire137 closed 8 years ago

cheshire137 commented 8 years ago

This branch adds:

Hmm, so the app starts, but the styling doesn’t seem to be applied. Any thoughts on this, @probablycorey?

cheshire137 commented 8 years ago

I spoke with @zeke about this yesterday, he thought he might be able to help!

zeke commented 8 years ago

👋 I haven't figured out the less issue yet, but I did notice that electron is in the dependencies, which could be screwing things up. That package name is a different project. Fortunately, that user has graciously handed over the electron npm name to us, but we haven't yet published something like electron-prebuilt in its place.

cheshire137 commented 8 years ago

Hm, I got this branch updated with master just now and electron is no longer a dependency in package.json.

zeke commented 8 years ago

The Less configuration seems right, but I'm not seeing the styles.

I tried debugging with DEBUG=*,-babel npm start, but didn't see any issues in the logs.

@paulcbetts do you see any obvious signs of misconfiguration here?

anaisbetts commented 8 years ago

I'll have a look in a hot second

anaisbetts commented 8 years ago

@cheshire137 Ok, tracked this down, it turns out I am not good at computer

anaisbetts commented 8 years ago

Ok! Blow away node_modules and reinstall so that you get electron-compilers@3.1.6 and this should just work. You should also go into $TMPDIR and remove any folder that starts with compileCache

cheshire137 commented 8 years ago

Thank you, it works!

screen shot 2016-07-20 at 1 22 50 pm

I checked out your commits--thanks for helping!

zeke commented 8 years ago

👏