search

cheshire137 / gh-notifications-snoozer

Lists and filters and snoozing pull requests, oh my! This is an app for managing your notifications on GitHub by way of filtering issues and pull requests that are of interest to you.
MIT License
15 stars 10 forks source link

Use redux to list tasks #14

Closed probablycorey closed 8 years ago

probablycorey commented 8 years ago

This is a SUPER WIP for adding redux. I'm just opening the PR now to give visibility to me working on it. When I'm ready for review I'll write a new comment and update this body.

Closes #4

probablycorey commented 8 years ago

I think getting this PR in and getting the notifications changes in there might become too big. So I'm going to add the actual notification data in a new PR and update this to use dummy data. It will be easier to explain that way.

probablycorey commented 8 years ago

Ok, this is now ready. It is mostly just boilerplate for future usage, but I would rather keep the PR simple and put more logic into followup PRs. If this looks good to you, we can follow it up with:

  1. A PR that uses the GitHub API to populate the tasks
  2. A PR that uses enzyme to test components
  3. A PR that uses actions instead of raw calls to dispatch
  4. A PR that adds tests the actions and reducer
cheshire137 commented 8 years ago

Here we go!

probablycorey commented 8 years ago

💥