search

cheshire137 / gh-notifications-snoozer

Lists and filters and snoozing pull requests, oh my! This is an app for managing your notifications on GitHub by way of filtering issues and pull requests that are of interest to you.
MIT License
15 stars 10 forks source link

Add tabbed navigation #71

Closed summasmiff closed 8 years ago

summasmiff commented 8 years ago

Creates a primary tabbed navigation for the app. Adds a secondary navigation for certain screens if they need additional functionality.

Everything is working fine, but I want to refactor the main render function in App.jsx to reduce some of the duplication. Done!

Needs some tests Done! screen shot 2016-09-22 at 3 16 19 pm

cheshire137 commented 8 years ago

So excite! 😄 How do you foresee this incorporating #68? Viewing your hidden tasks doesn't seem a primary thing users will want to do, it's more for when you accidentally click the wrong thing and want to restore something. So it needs to be accessible but not prominently.

Figuring out a good way to get at your hidden tasks when both branches land can come in a followup branch, it doesn't have to happen in here before this lands.

summasmiff commented 8 years ago

Re: #68, I think we can replace the "With selected: Snooze * Archive * Delete" with the "View: Snoozed * Archived * Deleted" after we move the snooze / archive / delete to be inline with notifications ( #38 ).

Ideally, the secondary nav should be for operations that aren't specific to any singular item but are sort of general to the current page, eg, add a new filter to the FilterList. Individual operations should all be inline with the item they affect.

summasmiff commented 8 years ago

Hey @cheshire137 : any thoughts about the use of the 'X' button? I think I've addressed the rest of your comments!

cheshire137 commented 8 years ago

Ooh now you got conflicts, son. Sorry about the merge!

summasmiff commented 8 years ago

Do we want to call them "Notifications" or "Tasks"?

cheshire137 commented 8 years ago

User-facing I think they should always be tasks. In the code, some things are notifications because they come from the GitHub notifications API. Most of the data is coming from the issues API and they aren't actual notifications, they're just issues and PRs that the user is searching for via their filters. But many of these issues/PRs are tied to open notifications on GitHub for the user, so we mark those notifications as read, if they exist, once the user archives/ignores/snoozes a task.

summasmiff commented 8 years ago

Cool. Updating this to use the "task" nomenclature in the UI exclusively.

cheshire137 commented 8 years ago

I updated your tests! 🙆

cheshire137 commented 8 years ago

In we gooooo! Thanks! 😀