Allow editing a filter inline - Githubissues

cheshire137 / gh-notifications-snoozer

Lists and filters and snoozing pull requests, oh my! This is an app for managing your notifications on GitHub by way of filtering issues and pull requests that are of interest to you.

MIT License

15 stars 10 forks source link

Allow editing a filter inline #73

Open summasmiff opened 8 years ago

summasmiff commented 8 years ago

If we can display a filter's value on the filter list page, I don't see why we can't add an inline edit for that same filter.

User visits the filter list page and clicks the pencil next to a filter to edit it.
The filter value becomes a text field populated with the current filter, and the pencil becomes a checkmark.
The user can edit the value of the filter, and then click the checkmark to finish editing. The filter list returns to its original state.

Potential downsides:

Inability to edit filter's name (current mockup)
If we give the ability to edit the name and value, having two text fields open up for each filter might be confusing to the user

Mockup:

mockup

probablycorey commented 7 years ago

I :heart: this idea!