cheshire137 / soma-chrome

Chrome extension to listen to SomaFM web radio stations from your browser.
https://chrome.google.com/webstore/detail/somaplayer/dpcghdgbhjkihgnnbojldhjmcbieofgo?hl=en&gl=US&authuser=1
MIT License
58 stars 20 forks source link

Creates multiple notifications #4

Open webmink opened 9 years ago

webmink commented 9 years ago

First, thanks so much for making this, I really like it! My apologies for not making a pull request but I'm not set up for development here (just a Chromebook...)

I notice you've left the notification ID empty in chrome.notifications.create, so every new track creates a new notification. That may be your desired behaviour, but if I'm reading the documentation right, if you set a value for notification ID the function will clear any previous notification when a new track plays.

cheshire137 commented 9 years ago

That's a good idea. I'll look into this.