search

cheshirekow / cmake_format

Source code formatter for cmake listfiles.
GNU General Public License v3.0
958 stars 105 forks source link

Added missing parenthesis #141

Closed sergeyklay closed 4 years ago

sergeyklay commented 4 years ago

@cheshirekow Could you please take a look? It seems Travis' fails unrelated

cheshirekow commented 4 years ago

Travis fail is real, even if the output isn't very informative. See: https://github.com/cheshirekow/cmake_format/blob/master/cmake_format/doc/contributing.rst#copyright-assignment

======================================================================
FAIL: test_commit_signer_has_signed_ca (__main__.TestContribution)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/cheshirekow/cmake_format/cmake_format/contrib/validate_pullrequest.py", line 163, in test_commit_signer_has_signed_ca
    .format(signer_encoded))
AssertionError: Could not find signer 4AEE18F83AFDEB23 in signature database

But your change is a trivial doc change, so no worries... I'll pull it in.

sergeyklay commented 4 years ago

Closed in favor of #149