search

cheshirekow / cmake_format

Source code formatter for cmake listfiles.
GNU General Public License v3.0
969 stars 108 forks source link

Fixed typos and bugs in vscode extension #187

Closed UebelAndre closed 4 years ago

UebelAndre commented 4 years ago

At first I just wanted to fix a typo but I found some other issues. I was having issues setting a path and couldn't get anything to run. It looks like the extension was incompatible with the current release of cmake-format? Anyway, this fixes it for me

UebelAndre commented 4 years ago

Does this mean there's something wrong with my account? What is this test failure?

======================================================================

ERROR: test_commit_is_signed (__main__.TestContribution)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/cheshirekow/cmake_format/cmake_format/contrib/validate_pullrequest.py", line 119, in test_commit_is_signed

    signer_encoded])

  File "/opt/python/3.6.7/lib/python3.6/subprocess.py", line 291, in check_call

    raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command '['gpg', '--keyserver', 'keyserver.ubuntu.com', '--recv-keys', '']' returned non-zero exit status 2.

======================================================================

FAIL: test_commit_signer_has_signed_ca (__main__.TestContribution)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/cheshirekow/cmake_format/cmake_format/contrib/validate_pullrequest.py", line 163, in test_commit_signer_has_signed_ca

    .format(signer_encoded))

AssertionError: Could not find signer  in signature database

----------------------------------------------------------------------

Ran 4 tests in 1.326s

FAILED (failures=1, errors=1)
cheshirekow commented 4 years ago

At first I just wanted to fix a typo but I found some other issues. I was having issues setting a path and couldn't get anything to run.

Outside of the split and delim typos, what other issues did you encounter?

It looks like the extension was incompatible with the current release of cmake-format? Anyway, this fixes it for me

It works fine for me. It should be compatible with the current release.

cheshirekow commented 4 years ago

Does this mean there's something wrong with my account? What is this test failure?

Please see: https://cmake-format.readthedocs.io/en/latest/contributing.html#pull-requests

UebelAndre commented 4 years ago

Outside of the split and delim typos, what other issues did you encounter?

I can't actually reproduce them. I was getting a lot of spawnSync cmake-format ENOENT errors and just wanted to use the extension. I may have over done it when I saw all the typescript warnings in the extensions.ts file.

I've updated the PR to contain only the typo fixes as that seems to work for me too.

That said, if you have time to address the older comments that'd be appreciated.

UebelAndre commented 4 years ago

Hey @cheshirekow What's the issue here? Sorry if it's something obvious 😃 

[100%] Decrypting cmake-format.deploy_key

iv undefined

cmake_format/doc/CMakeFiles/push-github-pseudorelease-tag.dir/build.make:61: recipe for target 'cmake_format/doc/cmake-format.deploy_key' failed

make[3]: *** [cmake_format/doc/cmake-format.deploy_key] Error 1

make[3]: *** Deleting file 'cmake_format/doc/cmake-format.deploy_key'

CMakeFiles/Makefile2:1190: recipe for target 'cmake_format/doc/CMakeFiles/push-github-pseudorelease-tag.dir/all' failed

make[2]: *** [cmake_format/doc/CMakeFiles/push-github-pseudorelease-tag.dir/all] Error 2

CMakeFiles/Makefile2:1197: recipe for target 'cmake_format/doc/CMakeFiles/push-github-pseudorelease-tag.dir/rule' failed

make[1]: *** [cmake_format/doc/CMakeFiles/push-github-pseudorelease-tag.dir/rule] Error 2

Makefile:532: recipe for target 'push-github-pseudorelease-tag' failed

make: *** [push-github-pseudorelease-tag] Error 2

Makefile:20: recipe for target 'push-github-pseudorelease-tag' failed

make: *** [push-github-pseudorelease-tag] Error 2

The command "make push-github-pseudorelease-tag" exited with 2.
cheshirekow commented 4 years ago

Hey @cheshirekow What's the issue here? Sorry if it's something obvious

Hm... it looks like travis is trying to run the deploy pipeline. It isn't supposed to, for a pull request. I'll have to have a look at this.

UebelAndre commented 4 years ago

Hey @cheshirekow What's the issue here? Sorry if it's something obvious

Hm... it looks like travis is trying to run the deploy pipeline. It isn't supposed to, for a pull request. I'll have to have a look at this.

Sounds good. Let me know if there's anything I can do to help. Looking forward to your response.

cheshirekow commented 4 years ago

Do you know much about travis? I was under the impression that the deploy stage was skipped automatically for pull requests. It seems that is not the case?

Maybe it doesn't matter, I think I know how to skip it manually. I'll try that.

UebelAndre commented 4 years ago

Do you know much about travis? I was under the impression that the deploy stage was skipped automatically for pull requests. It seems that is not the case?

Maybe it doesn't matter, I think I know how to skip it manually. I'll try that.

Hey, sorry, no, I've never used Travis before 😞