search

cheshirekow / cmake_format

Source code formatter for cmake listfiles.
GNU General Public License v3.0
954 stars 105 forks source link

What is "upstream"? #200

Closed rpavlik closed 4 years ago

rpavlik commented 4 years ago

When looking at old pull requests to try to figure out maintenance, etc. practices (and why so many requests were just closed without merge, and each commit is a massive monolithic change corresponding to a release) - I noticed this: https://github.com/cheshirekow/cmake_format/pull/149#issuecomment-555339584

"But don't sweat it, I've pulled your typo fixes in upstream and I'll include them in the next push."

Is there some other repository that is "upstream" that changes should be submitted to? Or is this mostly an internal project made source-available, with github as a release system?

I really like this functionality - works better than my personal, earlier attempt to do something similar (in a much less complete way) and would like to participate, but I'm confused by the signs whether the sorts of "drive-by contributions" I typically start with are desired.

cheshirekow commented 4 years ago

Or is this mostly an internal project made source-available, with github as a release system?

This one. Though "source-available" usually means something different than how you're using it, and github is more for issue reporting than release. pypi is for release.

"drive-by contributions" I typically start with are desired.

Meaningful contributions are definitely welcome.

rpavlik commented 4 years ago

Thanks for clarification! The git history had me confused.