search

chesio / bc-cache

Simple full page cache plugin for WordPress inspired by Cachify
The Unlicense
9 stars 0 forks source link

Many sources add a GET parameter #26

Closed szepeviktor closed 5 years ago

szepeviktor commented 5 years ago

Cache skipping may be inappropriate when !empty($_GET).

  1. ~WordPress post ID ?p=~
  2. Google Ads ?gclid= "Google Click Identifier"
  3. All links on Facebook ?fbclid
  4. Google Analytics tagging ?utm*
  5. many others...

Please reconsider this.

chesio commented 5 years ago

Fair point. I guess a filter could be added to ignore specific query string variables when making this check.

I assume Google/Facebook (campaign) tracking identifiers can be ignored by default. I'm not sure about WordPress post ID - I give it a thought.

szepeviktor commented 5 years ago

Hard to be a FPC plugin manufacturer!

chesio commented 5 years ago

Hard to be a FPC plugin manufacturer!

It's not - I like programming :-)

chesio commented 5 years ago
  1. WordPress post ID ?p=

I just checked that on a website with pretty permalinks active, requests with ?p= in URL are automatically redirected to pretty permalink version, so there is nothing to be done here.

szepeviktor commented 5 years ago

Some website may not use pretty links.

szepeviktor commented 5 years ago

Have you received my email? It is about a WooCommerce job.

chesio commented 5 years ago

Have you received my email? It is about a WooCommerce job.

I did. I'm sorry I'm letting you wait, I'm going through quite busy period right now. I'll get to your emails over weekend.

chesio commented 5 years ago

Some website may not use pretty links.

I decided to not support these on purpose as it makes things more complex and I didn't have any incentive to deal with the additional complexity (= have no site that do not use pretty permalinks).

Anyway, your suggestion to ignore tracking identifiers makes sense, so I'll keep this issue open.

szepeviktor commented 5 years ago

Okay, I am very-very weak on manufacturing software for non-professionals, for the masses.

So my cache solution has no UI, and it is a the_content-only cache but is caches nav menus, widgets and translations too.

chesio commented 5 years ago

So my cache solution has no UI, and it is a the_content-only cache but is caches nav menus, widgets and translations too.

It's an interesting approach, I might try your cache in some future project.

szepeviktor commented 5 years ago

It's an interesting approach, I might try your cache in some future project.

Okay @chesio ! Currently I develop get_template_part() caching.