search

chesio / bc-cache

Simple full page cache plugin for WordPress inspired by Cachify
The Unlicense
9 stars 0 forks source link

Improve CI #84

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

kép

Voila! :)

chesio commented 2 years ago

Thank you Viktor! I'll take some time to review - plenty of new stuff for me 😮

szepeviktor commented 2 years ago

This lowest deps thing is tough stuff! I'm not jealous of you.

chesio commented 2 years ago

This lowest deps thing is tough stuff! I'm not jealous of you.

Sadly I have no idea how to deal with reported the error - there is nothing returned from the mentioned method, it's as void as it can be... 🆘

chesio commented 2 years ago

This lowest deps thing is tough stuff! I'm not jealous of you.

Sadly I have no idea how to deal with reported the error - there is nothing returned from the mentioned method, it's as void as it can be... 🆘

Ok, I can reproduce the 💥 locally, so I'll debug...

chesio commented 2 years ago

@szepeviktor Problem solved! 😄

Just for fun I have tracked it down to this issue: https://github.com/antecedent/patchwork/issues/64 So I would have to add Patchwork as direct dependency just to pass the lowest tests, not really worth it.

chesio commented 2 years ago

Thanks a lot again! And now back to work... 💪

szepeviktor commented 2 years ago

You're welcome.