search

chessai / eigen

Haskell bindings to the Eigen C++ library
Other
16 stars 6 forks source link

missing functions from refactor #12

Open chessai opened 5 years ago

chessai commented 5 years ago

There are some functions missing after the refactor. They were simply forgotten when re-implementing the library. @GregorySchwartz brought some good ones up. If anyone notices any more, please report them here. I will be looking through and re-implementing them, taking note here.

GregorySchwartz commented 5 years ago

Thank you for re-adding those functions!

GregorySchwartz commented 5 years ago

What about diagRow, ident, getColSums, and getRowSums? Can you make a new release with these?

GregorySchwartz commented 5 years ago

Basically, everything from my initial pull request in the old repository that isn't in the new one:

squareSubset
ones
ident
diagCol
diagRow
getRowSums
getColSums
getSum
chessai commented 5 years ago

Yes, I can get this out tomorrow.

GregorySchwartz commented 5 years ago

What is the status of these functions?

chessai commented 5 years ago

@GregorySchwartz they exist in a branch, but I introduced a bug on that branch so it's blocked on merging. Sorry for not delivering; ive been incredibly busy. I have not forgotten about this.

GregorySchwartz commented 5 years ago

@chessai Is there a way to help this merge along?

chessai commented 5 years ago

@GregorySchwartz sorry for the extreme delay. I haven't had as much time to work on features. When working on this branch I introduced a bug, which stalled me, since I was expecting this to not take very long. It might make the most sense to add these functions on a branch from the current master, rather than the branch i was working on. If you are able to work on a PR that would be very helpful in getting these functions merged in!