Closed consideRatio closed 4 years ago
I think you can delete package-lock.json
and update tsconfig.json like this
@zhytang ah that would make everything more in line with the current cookiecutter template to create a jupyterlab extension, but I didn't see package-lock.json be in the .gitignore, so I think the cookiecutter is opinionated towards including it.
when NPM is used to publish packages, package-lock.json will not be published, so I think we can add it to the .gitignore. It's just a suggestion
@zhytang i updated this extension based on the jupyterlab extensions cookiecutter repo: https://github.com/jupyterlab/extension-cookiecutter-ts
I didn't remove package-lock.json as it would go against the typical practice I've seen across many other jupyterlab extensions as well as this repo.
@chaoleili if you have time, this is ready for review/merge I'd say!
@chaoleili if you have time, this is ready for review/merge I'd say!
Thanks a lot for your contribution! 🎉
JupyterLab 2.0.0 is out, and this extension have conflicting dependencies with its core packages. This PR is me following the JupyterLab migration guide referenced below, as I have now done for many other repositories successfully.
PR Summary
References