search

chesterli29 / jupyterlab_tensorboard

Tensorboard extension for jupyterlab.
MIT License
314 stars 36 forks source link

Move Tensorboards to Running Panel #23

Closed Queuecumber closed 4 years ago

Queuecumber commented 4 years ago

This PR finally fixes the last of the UI inconsistencies by moving the tensorboards from their own panel into the main running panel, this is a new API in jupyterlab 2.

This API also enforces the new icon API so I added that as well for consistency.

Fixes #13

Queuecumber commented 4 years ago

There are a couple of things to look over with this:

  1. I had build errors unless I completely blew away the package-lock.json and rebuilt it, so it's worth checking if that is in a safe state
  2. I tried to remove as much dead code as possible, since this change would obsolete a large portion of the existing code. It is a good idea to check that I wasn't too aggressive in this, or that I didn't miss anything which could be removed.
Queuecumber commented 4 years ago

There are a couple of things still outstanding with these changes from my point-of-view. First off in the status bar, it still only shows terminals and kernels, I don't see an option to add anything to that bar. If/when that API opens up this should be updated again. Next, the old CSS based icons are still being used by tab.ts. I have a hunch there is a way to convert that over to the new icon API as well but I'm not sure how to do it.

chesterli29 commented 4 years ago

@Queuecumber Thanks a lot for this ! Great Job!

  1. Building error on old package-lock.json is maybe my mistake, and doesn't update dependency in time.
  2. It's ok to remove dead code, it will make the code clear, thanks again.