search

chestm007 / linux_thermaltake_riing

Python driver and daemon to control thermaltake Riing fans and pumps
GNU General Public License v2.0
59 stars 25 forks source link

Systemd service changes #17

Closed nicoulaj closed 5 years ago

nicoulaj commented 5 years ago

Here a set of proposed changes regarding the systemd service:

  1. Change to a system instead of a user service. In the general case (single user machine) we want this service to run from boot to shutdown, not only on user session. Using a user service forces users to enable lingering to achieve that. This change also removes the need for specific udev rules / plugdev group.
  2. Enable more hardening options.
  3. Add support for optional /etc/default/linux-thermaltake-rgb file (can contain DEBUG=true).
  4. Add delay between restarts.
  5. Change back executable path to the default /usr/bin. It is downstream packagers job to adapt the service file if they don't deploy to the standard location.

Some of these might be controversial, so open for discussion ;)