chestm007 / linux_thermaltake_riing

Python driver and daemon to control thermaltake Riing fans and pumps
GNU General Public License v2.0
59 stars 25 forks source link

Too much processor usage #41

Open rkmax opened 4 years ago

rkmax commented 4 years ago

Describe the bug I have 120mm TT Premium Plus RGB with 3 fans, as soon set lighting_manager to temperature and fan_manager to curve the process start using between 2-4% of the processor which I think is too much. with other settings like locked_speed and full or ripple, the process take 0% (basically a very low number), my procesor is a i7 8700

With any other settings

Screenshot from 2020-05-23 02-57-58

With the temperature and curve settings

Screenshot from 2020-05-23 02-59-19

here's my config.yml

#####################################################################
#
#  This default config file outlines most of the configuration
#   possible using this software, probably don't uncomment it all
#
#####################################################################

controllers:
  - unit: 1
    type: g3
    devices:
      1: Riing Plus
      2: Riing Plus
      3: Riing Plus
#      4: Riing Plus
#      5: Floe Riing RGB
#  - unit: 1
#    type: riingtrio
#    devices:
#      1: Riing Plus  # These are incorrectly specified as Riing Plus
#      2: Riing Plus  # there is nothing in the code that will break this
#      3: Riing Plus  # but we should not be doing confusing things like this
#                     # TODO: implement better fan naming schemes
#  - unit: 2
#    type: g3
#    devices:
#      1: Riing Plus
#      2: Riing Plus
#      3: Riing Plus
#      4: Pacific V-GTX 1080Ti Plus GPU Waterblock
#      5: Pacific W4 Plus CPU Waterblock
#  - unit: 3
#    type: g3
#    devices:
#      1: Riing Plus
#      2: Riing Plus
#      3: Riing Plus
#      4: Pacific V-GTX 1080Ti Plus GPU Waterblock
#      5: Pacific PR22-D5 Plus
#  - unit: 4
#    type: g3
#    devices:
#      1: Riing Plus
#      2: Riing Plus
#      3: Riing Plus
#      4: Pacific V-GTX 1080Ti Plus GPU Waterblock
#      5: Lumi Plus LED Strip
#  - unit: 5
#    type: g3
#    devices:
#      1: Riing Plus
#      2: Riing Plus
#      3: Riing Plus
#      4: Riing Plus
#      5: Lumi Plus LED Strip

fan_manager:
#  model: locked_speed
#  speed: 55

#  model: temp_target
#  target: 38
#  sensor_name: k10temp
#  multiplier: 5

  model: curve
  points:
    - [30, 0]  # [temp(*C), speed(0-100%)]
    - [40, 50]
    - [60, 100]
  sensor_name: coretemp

lighting_manager:
# speed: normal

  model: temperature
  sensor_name: coretemp
  cold: 30
  target: 40
  hot: 60
  speed: extreme

#  model: alternating
#  odd_rgb:
#    r: 50
#    g: 0
#    b: 0
#  even_rgb:
#    r: 0
#    g: 50
#    b: 0

#  model: full
  r: 87
  g: 198
  b: 63

#  model: flow

#  model: spectrum

#  model: ripple
#  r: 50
#  g: 0
#  b: 0

#  model: blink
#  r: 50
#  g: 0
#  b: 0

#  model: pulse
#  r: 50
#  g: 0
#  b: 0

Expected behavior too use 1% or less I have a processor with 6 cores and 12 threads basically for regular use is always under ~41°C and the noctua fan round ~200rpm and with the previous settings will keep up 46°C and processor fan around the double

Desktop (please complete the following information):

chestm007 commented 1 year ago

Optimizing has always been on my to do list, but the cpu usage never bothered me personally enough to get me to start hunting for improvements yet, I definitely welcome contributions that improve that however.