chetachiezikeuzor / Yin-and-Yang-Theme

An Obsidian.md theme with a stark contrast between dark mode and light mode, much like the Yin and Yang symbol ☯️.
Mozilla Public License 2.0
539 stars 42 forks source link

Mobile bugs plus 1 request #12

Open zeshalta opened 3 years ago

zeshalta commented 3 years ago

As requested from reddit listing mobile bugs that I’ve encountered with the theme. Mostly just looking for a fix for the fold headings bug - the others are bonus.

Not certain if the bugs below are theme issues or more the Style Settings plugin that your theme works with:

If i could make one request, it would be the option to change the text size of the file explorer. Again, not sure if this is.

Thank you for your efforts :)

chetachiezikeuzor commented 3 years ago

For the "all headings remain the same size" issue: Can I ask, when was the last time you updated the theme? I made a ton of changes, including heading resizing. Not sure if this will solve the issue but I just wanted to be sure. :) Thanks!

Mara-Li commented 3 years ago

Well, I update the theme and I have the same issue as him !

zeshalta commented 3 years ago

Can confirm it’s updated to the latest and the issue still persists (thank you for fixing the collapsible headings!!!).

Mara-Li commented 3 years ago

For my wysiwyg snippet, I try to change heading and don't success for the moment.

It's remind me the problem here, so, I think the problem here is the way heading is targeted.

After check the code, I found the culprit : you use codemirror line. And the code mirror line behavior change in mobile because of the 6 version. In my snippet I just erase this line to touch all things on mobile. With style settings, you can add a special class like .mobile in case it can break on pc. Or, you can use @media screen to target by screen size. I use the first solution with my snippet but I use media screen for other things and it's work.

I will try to do that to check if it's working and if it's codemirror line the culprit.

EDIT : good news! It was that. I try to just use @media screen and :

653957DE-772B-4A35-8014-4C18FD6A60F3

chetachiezikeuzor commented 3 years ago

After check the code, I found the culprit : you use codemirror line. And the code mirror line behavior change in mobile because of the 6 version.

Ah! I had no idea of this! I do need to get the mobile app so that I can tend to this properly, but this thorough response is extremely helpful! Thank you!

chetachiezikeuzor commented 3 years ago

I just released a brand new update to the theme! I'm still working on better WYS mode for mobile but heading size changes and headers in editor should work properly now. The enhanced typography is something I'm still trying to fix for mobile but it should be better in the desktop app. (I know it's taking me so long but) Change text size for file explorer will be coming soon! I just need to overhaul a few things with Style Settings. Thanks! @zeshalta